Add support for Vector2/3/4, Quaternion, Rect; expand support for RGB-only Color#89
Add support for Vector2/3/4, Quaternion, Rect; expand support for RGB-only Color#89kaycodes13 wants to merge 13 commits into
Conversation
To clarify that there's a spot to type when the field is empty.
kaycodes13
changed the title
dplochcoder
left a comment
dplochcoder
left a comment
There was a problem hiding this comment.
Mostly LG, just a couple comments left + Flib's comment about the RGB attribute
kaycodes13
changed the title
| textInputChild.FindChild("CursorRight")!.GetComponent<Animator>(), | ||
| ]; | ||
|
|
||
| GameObject underlineObj = new("Underline") { layer = (int)PhysLayers.UI }; |
There was a problem hiding this comment.
How wedded are you to this underline? I think it looked better without the underline, personally
(To be clear, I don't mean we should keep - or remove - it based solely on my opinion, but I'd like it to be scrutinized further)
There was a problem hiding this comment.
My concern with text inputs is making what they are more immediately obvious. Without anything to make it visually distinct from other similar controls, a filled text field looks very similar to a choice element, and an empty text field looks like the choices for a choice element didn't load. Hovering over or otherwise navigating to a text field puts a selection effect or caret on it to make it clear what it is, sure, but the initial impression is still unclear.
My reasoning for choosing a thin underline is because it's familiar visual language for this kind of input - anyone who's filled out a paper form has seen an underline somewhere you're supposed to write something. It's a choice that favours clarity over aesthetics. But if someone has an idea for how to get better aesthetics and similar clarity, sure, I say we try it.
There was a problem hiding this comment.
I never thought they weren’t obvious without the line but I’ll have to have another look to judge. I do care a lot about aesthetics though so if there’s a better way to achieve what you want then that’d be good
3 participants
Summary of Changes
Closes #78 by:
TextModelsutilities to create models forVector2,Vector3,Vector4,Quaternion, andRecttypes.TextInput.ConfigEntryFactoryandMenuProperty.Other updates folded into this:
RGBElementFactoryfor source generation of color inputs that mirrors the effect thatRGBColorValueshas for config entry element generation.Checklist